ChrisHegarty commented on code in PR #13535:
URL: https://github.com/apache/lucene/pull/13535#discussion_r1665875714
##########
lucene/core/src/java/org/apache/lucene/index/ReadersAndUpdates.java:
##########
@@ -578,7 +578,8 @@ public synchronized boolean writeFieldUpdates(
// IndexWriter.commitMergedDeletes).
final SegmentReader reader;
if (this.reader == null) {
- reader = new SegmentReader(info, indexCreatedVersionMajor,
IOContext.READONCE);
+ IOContext context = info.info.getUseCompoundFile() ? IOContext.DEFAULT
: IOContext.READONCE;
Review Comment:
Reverting this results in the following failure:
```
java.lang.IllegalStateException: confined
at
__randomizedtesting.SeedInfo.seed([E35616674660C0C9:EB8233FC2A66214D]:0)
at
org.apache.lucene.store.MemorySegmentIndexInput.ensureNotConfined(MemorySegmentIndexInput.java:108)
at
org.apache.lucene.store.MemorySegmentIndexInput.clone(MemorySegmentIndexInput.java:539)
at
org.apache.lucene.store.MemorySegmentIndexInput$SingleSegmentImpl.clone(MemorySegmentIndexInput.java:661)
at
org.apache.lucene.tests.store.MockIndexInputWrapper.clone(MockIndexInputWrapper.java:94)
at
org.apache.lucene.tests.store.MockIndexInputWrapper.clone(MockIndexInputWrapper.java:30)
at
org.apache.lucene.codecs.CodecUtil.checksumEntireFile(CodecUtil.java:607)
at
org.apache.lucene.codecs.blocktreeords.OrdsBlockTreeTermsReader.<init>(OrdsBlockTreeTermsReader.java:100)
at
org.apache.lucene.tests.codecs.mockrandom.MockRandomPostingsFormat.fieldsProducer(MockRandomPostingsFormat.java:379)
at
org.apache.lucene.codecs.perfield.PerFieldPostingsFormat$FieldsReader.<init>(PerFieldPostingsFormat.java:328)
at
org.apache.lucene.codecs.perfield.PerFieldPostingsFormat.fieldsProducer(PerFieldPostingsFormat.java:390)
at
org.apache.lucene.index.SegmentCoreReaders.<init>(SegmentCoreReaders.java:98)
at
org.apache.lucene.index.SegmentReader.<init>(SegmentReader.java:95)
at
org.apache.lucene.index.ReadersAndUpdates.writeFieldUpdates(ReadersAndUpdates.java:581)
at org.apache.lucene.index.ReaderPool.commit(ReaderPool.java:353)
at
org.apache.lucene.index.IndexWriter.writeReaderPool(IndexWriter.java:3990)
at
org.apache.lucene.index.IndexWriter.prepareCommitInternal(IndexWriter.java:3692)
at
org.apache.lucene.index.IndexWriter.commitInternal(IndexWriter.java:4122)
at
org.apache.lucene.index.IndexWriter.shutdown(IndexWriter.java:1331)
at org.apache.lucene.index.IndexWriter.close(IndexWriter.java:1369)
at org.apache.lucene.util.IOUtils.close(IOUtils.java:85)
at org.apache.lucene.util.IOUtils.close(IOUtils.java:72)
at
org.apache.lucene.index.TestNumericDocValuesUpdates.testMultipleUpdatesSameDoc(TestNumericDocValuesUpdates.java:116)
...
```
`CodecUtil.checksumEntireFile` is cloning. It could just slice the whole
input.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
