uschindler commented on PR #13535: URL: https://github.com/apache/lucene/pull/13535#issuecomment-2209201436
> Thanks, looks fine now. I think we can revert the changes to the SegmentReader and look into this in another issue. It still looks strange not me, but I had not time to look closely into the code of the parts which used READONCE on CFS files, that you now changed to DEFAULT. > > If the code opens the CFS file and closes it later, using READONCE is fine, but not in general to open such a file. I reviewed this. We can undo the IOContext#DEFAULT changes for the CFS files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
