iverase commented on code in PR #13449:
URL: https://github.com/apache/lucene/pull/13449#discussion_r1629301507
##########
lucene/core/src/java/org/apache/lucene/index/FieldInfo.java:
##########
@@ -289,6 +302,24 @@ static void verifySameDocValuesType(
}
}
+ /**
+ * Verify that the provided docValues type are the same
+ *
+ * @throws IllegalArgumentException if they are not the same
+ */
+ static void verifySameDocValuesSkipIndex(
Review Comment:
I think you are right but I wonder if we should optimize first
FieldInfo.FieldNumbers. I open https://github.com/apache/lucene/pull/13460 for
consideration,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
