easyice commented on code in PR #13449:
URL: https://github.com/apache/lucene/pull/13449#discussion_r1629013375
##########
lucene/core/src/java/org/apache/lucene/index/FieldInfo.java:
##########
@@ -289,6 +302,24 @@ static void verifySameDocValuesType(
}
}
+ /**
+ * Verify that the provided docValues type are the same
+ *
+ * @throws IllegalArgumentException if they are not the same
+ */
+ static void verifySameDocValuesSkipIndex(
Review Comment:
Do we need to do the same check in `FieldInfos#verifySameSchema`?
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesConsumer.java:
##########
@@ -129,16 +131,17 @@ public void addNumericField(FieldInfo field,
DocValuesProducer valuesProducer)
throws IOException {
meta.writeInt(field.number);
meta.writeByte(Lucene90DocValuesFormat.NUMERIC);
-
- writeValues(
- field,
+ DocValuesProducer producer =
new EmptyDocValuesProducer() {
@Override
public SortedNumericDocValues getSortedNumeric(FieldInfo field)
throws IOException {
return DocValues.singleton(valuesProducer.getNumeric(field));
}
- },
- false);
+ };
+ if (field.hasDocValuesSkipIndex()) {
+ writeSkipIndex(field, producer);
Review Comment:
Do we need to check the skip index in `CheckIndex`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
