iverase commented on code in PR #13449:
URL: https://github.com/apache/lucene/pull/13449#discussion_r1629012824
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesProducer.java:
##########
@@ -197,6 +215,17 @@ private NumericEntry readNumeric(IndexInput meta) throws
IOException {
return entry;
}
+ private DocValuesSkipperEntry readDocValueSkipperMeta(IndexInput meta)
throws IOException {
+ long offset = meta.readLong();
+ long length = meta.readLong();
+ long minValue = meta.readLong();
+ long maxValue = meta.readLong();
+ int docCount = meta.readInt();
+ int maxDocID = meta.readInt();
+
+ return new DocValuesSkipperEntry(offset, length, minValue, maxValue,
docCount, maxDocID);
Review Comment:
The validation would look like:
```
assert length == 28 * (1 + ((docCount - 1) / SKIP_INDEX_INTERVAL_SIZE));
```
As before I am hesitant to add the validation at the moment as this might
change if we introduce levels.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
