jpountz commented on code in PR #13440:
URL: https://github.com/apache/lucene/pull/13440#discussion_r1620860434


##########
lucene/core/src/java/org/apache/lucene/search/Scorer.java:
##########
@@ -39,15 +39,6 @@ protected Scorer(Weight weight) {
     this.weight = Objects.requireNonNull(weight);

Review Comment:
   Can you also remove the `Weight` parameter from the constructor? This is the 
most annoying bit to me.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to