jpountz commented on PR #13440: URL: https://github.com/apache/lucene/pull/13440#issuecomment-2141965592
> few ctors have been reduced to default ctor. Should I removed those as well? For those that are in the `java` folder, I'd keep them and add javadocs (I thought the build checked that). For those under the `test` folder, we can remove. > Check: FunctionValues#getRangeScorer Good question. Your change looks good this way, but I know Solr is a heavy user of `FunctionValues`, I'm curious if that would be annoying to them. @gerlowskija @dsmiley @HoustonPutman Do you have an opinion on this? > SpatialQuery has also one method where we could possibly change the API to remove the weight parameter as it is not required now. Should I change that as well? Yes. It looks like it was only there to be able to pass the Weight to a Scorer constructor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
