iamsanjay commented on PR #13440:
URL: https://github.com/apache/lucene/pull/13440#issuecomment-2141366659
1. There were three classes that are using weight in some way so I leave
them to be for now.
`FunctionQuery#AllScorer`
https://github.com/apache/lucene/blob/750a7c4d3b3e174023404bf363861dae31413901/lucene/queries/src/java/org/apache/lucene/queries/function/FunctionQuery.java#L117
`TermAutomatonScorer`
https://github.com/apache/lucene/blob/750a7c4d3b3e174023404bf363861dae31413901/lucene/sandbox/src/java/org/apache/lucene/sandbox/search/TermAutomatonScorer.java#L68
`TestMinShouldMatch2#SlowMinShouldMatchScorer`
https://github.com/apache/lucene/blob/750a7c4d3b3e174023404bf363861dae31413901/lucene/core/src/test/org/apache/lucene/search/TestMinShouldMatch2.java#L357
2. As I removed weight, few ctors -- `JustCompileScorer`, `SimpleScorer`,
`TestScoreCachingWrappingScorer#SimpleScorer`, `Scorer` -- have been reduced to
default ctor. Should I removed those as well?
3. As we removing Weight, some APIs that were calling with weight is not
required. Hence I removed the weight from their method signature as well --
Check: FunctionValues#getRangeScorer and all the respective overrides.
4. `SpatialQuery` has also one method where we could possibly change the API
to remove the weight parameter as it is not required now. Should I change that
as well? There is a possibility we may found some more APIs where the weight
can be removed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
