carlosdelest commented on PR #13430: URL: https://github.com/apache/lucene/pull/13430#issuecomment-2137112864
Hi @jpountz , thanks for your thoughts! Let me check whether I got your suggestion right: - There are at most 2 segment tiers. The first has `minNumSegments` at most, the second `minNumSegments-1` to ensure we maintain `minNumSegments` total segments at the most. - The max number of docs allowed in a segment is (maxDocs - numDeletes) / minNumSegments. That avoids creating larger segments than necessary so we ensure there's `minNumSegments` segments at a minimum. Does it align with your thoughts? Some questions I have: - `segsPerTier` is not taken into account if `minNumSegments` is specified, correct? - In case segments reach `maxMergedSegmentBytes`, should we fall back to the previous `segsPerTier` behaviour? I see that `minNumSegments` is not a good name with this approach - I think `targetSearchConcurrency` makes sense to be explicit. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
