carlosdelest commented on code in PR #13430:
URL: https://github.com/apache/lucene/pull/13430#discussion_r1631094664


##########
lucene/core/src/java/org/apache/lucene/index/TieredMergePolicy.java:
##########
@@ -522,21 +550,28 @@ private MergeSpecification doFindMerges(
         final List<SegmentCommitInfo> candidate = new ArrayList<>();

Review Comment:
   @jpountz , what is your take on this? The problem with this condition as it 
stands now is that, in case we only have 10 eligible segments for merging, and 
we have a max allowed segments of 15, we won't try to merge segments (even 
though we may have 17 total segments, and 7 are not eligible).
   
   Should we take into account the total number of current segments vs the ones 
that are eligible? Would it make sense to try and do some merges to reduce the 
number of segments to the maximum allowed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to