uschindler commented on code in PR #13337: URL: https://github.com/apache/lucene/pull/13337#discussion_r1594719247
########## lucene/core/src/java21/org/apache/lucene/store/MemorySegmentIndexInput.java: ########## @@ -50,6 +51,7 @@ abstract class MemorySegmentIndexInput extends IndexInput implements RandomAcces final int chunkSizePower; final Arena arena; final MemorySegment[] segments; + final Optional<NativeAccess> nativeAccess; Review Comment: As this is a singleton, we can make it static and initialize it here. There's no need to pass the optional through constructors an have they in every clone. We may also make it static final on the provider, but that's unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
