rmuir commented on PR #13337:
URL: https://github.com/apache/lucene/pull/13337#issuecomment-2097001668

   Thanks Uwe, maybe the correct solution is to simply add the api and 
implement with `madvise()` for MMapDirectory, for now? To me this is just 
another `madvise` being hooked in.
   
   I feel the bytebuffer/thread dancing in bufferedindexinput is too much. I 
can't reason about `pendingPrefetch` and clones and all that. A simple 
fadvise() seems like a correct solution there as it happens asynchronously in 
the kernel without hassles: but there's no reason to hold back mmapdir which 
can use madvise() today.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to