uschindler commented on PR #13351: URL: https://github.com/apache/lucene/pull/13351#issuecomment-2101312191
ok, I pushed my changes: - `CI=true` is only useful for CI and preserves old behaviour - to enable default vectorization settings and enable Hotspot's C2 use `-Ptests.defaultvectorization=true` (we can change name of this property if you have a better name) - you can still pass custom JVM options and can still enforce interger vectors if needed. The above settings just changes the efaults The code is now quite clean, I did not yet cleanup the two source files. I only had to move the `jvmArgs` gradle test task setting to the `afterEvaluate`. I added a separate method to `project.ext` to evaluate the `tests.defaultvectorization`. We should really merge those 2 files as they are really depending on each other. And maybe decide to resolve all test options late (in afterEvaluate). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
