uschindler commented on PR #13351: URL: https://github.com/apache/lucene/pull/13351#issuecomment-2100606534
I have a little bit of problem with that. Our CI infrastructure passes `CI=true` and basically we only want there that the "make tests fast" JVM option is removed (it removes the setting to disable C2 compiler). The disabled C2 compiler is actually the reason why we disable the vectorization tests for normal developers, because they would run insanely slow without C2. But actually the CI is there to test all variants and it does not matter how slow it is. So actually the change here is contradictory to what CI should do. So my idea would be to just add another test property `-Ptests.useProductiveMode=true` (or similar) which then implies: - disable the "tiered stop at 1" setting from jvmargs. - use default vectorization and do not enforce integer vectors So that means: Any developer who wants to test the productive features of Lucene, needs to pass the property. This would slowdown tests a bit and vectorization is always used in the way how it would be in production. Other ideas how to name this parameter: - `-Ptests.useProductiveMode=true` - `-Ptests.defaultVectorization=true` - `-Ptests.enableIncubatorVectorization=true` or any else. The changes are quite simple. We just need to make some extra code to override the other ones if one of the above is setup. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
