uschindler commented on PR #13351: URL: https://github.com/apache/lucene/pull/13351#issuecomment-2102209208
> There is still one small issue. C2 will still be disabled if `default` is randomly selected, e.g. > > ``` > $ ./gradlew :lucene:core:testOpts | egrep ".*defaultvectorization.*|.*vectorsize.*|.*forceintegervectors.*|.*jvmargs.*" > tests.defaultvectorization = false # Uses defaults for running tests with correct JVM settings to test Panama vectorization (tests.jvmargs, tests.vectorsize, tests.forceintegervectors). > C tests.forceintegervectors = false # (!= default: computed) Forces use of integer vectors even when slow. > C tests.jvmargs = -XX:TieredStopAtLevel=1 -XX:+UseParallelGC -XX:ActiveProcessorCount=1 # (!= default: computed) Arguments passed to each forked JVM. > C tests.vectorsize = default # (!= default: computed) Sets preferred vector size in bits. > ``` > > we want to enable C2 if the Panama Vector is enabled. Actually that's wanted: Because we want tests by default run fast. For that the CI env var sets empty jvmargs. With your latest change we randomly slowdown the tests. So please revert your commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
