benwtrent commented on code in PR #13321:
URL: https://github.com/apache/lucene/pull/13321#discussion_r1581482527
##########
lucene/core/src/java21/org/apache/lucene/internal/vectorization/PanamaVectorUtilSupport.java:
##########
@@ -390,22 +391,139 @@ private int dotProductBody128(byte[] a, byte[] b, int
limit) {
}
@Override
- public int int4DotProduct(byte[] a, byte[] b) {
+ public int int4DotProduct(byte[] a, boolean apacked, byte[] b, boolean
bpacked) {
+ if (apacked && bpacked) {
Review Comment:
AH! Good point @uschindler . I will adjust since these are internal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
