uschindler commented on code in PR #13321:
URL: https://github.com/apache/lucene/pull/13321#discussion_r1581305081
##########
lucene/core/src/java21/org/apache/lucene/internal/vectorization/PanamaVectorUtilSupport.java:
##########
@@ -390,22 +391,139 @@ private int dotProductBody128(byte[] a, byte[] b, int
limit) {
}
@Override
- public int int4DotProduct(byte[] a, byte[] b) {
+ public int int4DotProduct(byte[] a, boolean apacked, byte[] b, boolean
bpacked) {
+ if (apacked && bpacked) {
Review Comment:
Actually, those checks here are not needed at all, because this is not a
public API. Checks like the vector length is identical is in VectorUtil.
VectorUtil also never passes both true.
Maybe make an assertion of it. Same applies for the default impl.
##########
lucene/core/src/java/org/apache/lucene/internal/vectorization/DefaultVectorUtilSupport.java:
##########
@@ -152,7 +152,23 @@ public int dotProduct(byte[] a, byte[] b) {
}
@Override
- public int int4DotProduct(byte[] a, byte[] b) {
+ public int int4DotProduct(byte[] a, boolean apacked, byte[] b, boolean
bpacked) {
+ if (apacked && bpacked) {
Review Comment:
see below!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
