benwtrent commented on PR #13200: URL: https://github.com/apache/lucene/pull/13200#issuecomment-2032971207
@uschindler > We can remove all old classes then and just adopt reader code for the old codec to make it able to read the old byte values as identifier for similarities and just map them to strings for SPI lookup. There are many places still using the deprecated logic internally mainly because I haven't gone through and cleaned them all up as we have never decided that this is 100% the direction we wanted to go. The main places where the old enum is used on write is `[Byte|Float]VectorField` those and their companion queries are marked as `experimental`. So, I can remove the interaction there pretty easily. Then the enumeration could flagged as deprecated so that external users can stop using it. I am sure its being used more generally outside of the codecs themselves. `VectorSimilarityFunction` isn't flagged as experimental itself, and is sitting in the `index` package. Makes me think that it could be being used. So any upgrade path would require us deprecating it and providing an alternative no? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
