ChrisHegarty commented on code in PR #13200: URL: https://github.com/apache/lucene/pull/13200#discussion_r1544448539
########## lucene/core/src/java/org/apache/lucene/codecs/FloatVectorProvider.java: ########## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.codecs; + +import java.io.IOException; + +/** + * Provides access to a float vector value. + * + * @lucene.experimental + */ +public interface FloatVectorProvider { + /** + * Returns the float vector value for the given target ordinal. + * + * @param targetOrd the ordinal of the target vector + * @return the float vector value + */ + float[] vectorValue(int targetOrd) throws IOException; Review Comment: Getting a vector value here looks right, but the I wanna see if we can push is a little lower-level! what's going on here is that the vectorValue method seeks to the targetOrd * vector_dims. This is convenient, but ultimately depends on the underlying access to the data. Maybe these providers can have a common supertype that allows low-level access, all we need is access to the `IndexInput`, `dims`, and `size` - number of vectors. Then an implementation can choose how to access the data, if it pleases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
