benwtrent commented on PR #13200: URL: https://github.com/apache/lucene/pull/13200#issuecomment-2023902003
Tests still all fail, but now I think it compiles. Many deprecation warnings to go through and clean up still. One concern I had was on `FieldInfo`. Do we want to ask for a fully realized `VectorSimilarity` object or the String name by which it should be loaded? As for the interface for the API itself, it seems OK, but due to the old API, we were doing some weird things with the random vector scorers, etc. I need to revisit all that to see whats up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
