uschindler commented on PR #13196: URL: https://github.com/apache/lucene/pull/13196#issuecomment-2016481753
> It's not the fault of the PR, but it's almost impossible for me to follow what-happens-when thru the iocontext. Maybe we can overhaul it in trunk... I don't think we should add our own layer of abstraction here (I know that's "java"-style to do but it's wrong). It would be clearer if we just used madvise semantics directly: then you could see MADV_RANDOM from the code opening the file and understand what happens. Please do the change to IOContext separately. We need an abstraction anyways, because not all platforms have same constants. We may add another layer between IOContext and madvise, but that's out of the scope of this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
