uschindler commented on code in PR #13196: URL: https://github.com/apache/lucene/pull/13196#discussion_r1536612333
########## lucene/core/src/java/org/apache/lucene/store/IOContext.java: ########## @@ -124,6 +142,7 @@ public int hashCode() { result = prime * result + ((flushInfo == null) ? 0 : flushInfo.hashCode()); result = prime * result + ((mergeInfo == null) ? 0 : mergeInfo.hashCode()); result = prime * result + (readOnce ? 1231 : 1237); + result = prime * result + (randomAccess ? 1249 : 1259); Review Comment: Actually we should in main change this class to be a "record". Then equals/hashcode is a no-brainer (as autogenerated by invokedynamic). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org