rmuir commented on PR #13196: URL: https://github.com/apache/lucene/pull/13196#issuecomment-2016455406
It's not the fault of the PR, but it's almost impossible for me to follow what-happens-when thru the iocontext. Maybe we can overhaul it in trunk... I don't think we should add our own layer of abstraction here (I know that's "java"-style to do but it's wrong). It would be clearer if we just used madvise semantics directly: then you could see MADV_RANDOM from the code opening the file and understand what happens. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
