uschindler commented on PR #13196: URL: https://github.com/apache/lucene/pull/13196#issuecomment-2014854516
> > > One thing: Should we remove the NoopNativeAccess class and just add a null check? > > > > > > Null is a little easier to reason about in the code at the use-site, since the reader is singled that the action may not happen (if null), rather than assuming the advise be given unconditionally. > > So your recommendation is also to remove it. Will do later. I removed it and used an Optional (looks better than null check). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
