uschindler commented on code in PR #13196:
URL: https://github.com/apache/lucene/pull/13196#discussion_r1535348590
##########
lucene/core/src/java/org/apache/lucene/store/IOContext.java:
##########
@@ -54,14 +60,16 @@ public enum Context {
public static final IOContext DEFAULT = new IOContext(Context.DEFAULT);
- public static final IOContext READONCE = new IOContext(true, false);
+ public static final IOContext READONCE = new IOContext(true, false, false);
+
+ public static final IOContext READ = new IOContext(false, false, false);
- public static final IOContext READ = new IOContext(false, false);
+ public static final IOContext LOAD = new IOContext(false, true, false);
Review Comment:
MMapDirectory's preload feature is currently always taking precendence:
https://github.com/apache/lucene/pull/13196/files#diff-8681a7b2259f78a6d0d2efe4894ef79ce4697c3825d24675248bc557617773ceL93
If preload is set, it does not use madvise at all. We can change that, too,
but I think MADV_NORMAL fits best here. If we preload files we want them to be
in RAM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
