uschindler opened a new pull request, #13146: URL: https://github.com/apache/lucene/pull/13146
This PR updates the MR-JAR parts to only have implementations of Java 21. This PR does not remove the sourceSets for Java 21, although this is also our base version: - When compiling vector we need a apijar anyways as APIs change in every java release. - In Java 21, MemorySegment is still a preview API, so we need to compile against the apijar, too. Because compiling against the APIJAR is a hack, we do not want to do this for the main sourceset. So this one still has a separate sourceset with the Java 21 classes of vector and memorysegment. In the current state the Java 21 classes are still put into a MR-JAR part. I don't want to remove this for now: - We will need more vector source sets in future (not yet for Java 22) We *could* merge the Java 21 classes into the main part of the JAR file. The Gradle code could just compare the base version with the MR-JAR sourceset and if the version is identical (minJavaVersion==sourcesetVersion) it could copy the files into the main part of the JAR. I will try this in a separate commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
