rmuir commented on code in PR #13146:
URL: https://github.com/apache/lucene/pull/13146#discussion_r1507949364
##########
lucene/core/src/test/org/apache/lucene/store/TestMMapDirectory.java:
##########
@@ -36,30 +34,7 @@ protected Directory getDirectory(Path path) throws
IOException {
return m;
}
- @BeforeClass
- public static void beforeClass() throws Exception {
- assertTrue(MMapDirectory.UNMAP_NOT_SUPPORTED_REASON,
MMapDirectory.UNMAP_SUPPORTED);
- }
-
- private static boolean isMemorySegmentImpl() {
- return Objects.equals(
- "MemorySegmentIndexInputProvider",
MMapDirectory.PROVIDER.getClass().getSimpleName());
- }
-
- public void testCorrectImplementation() {
- final int runtimeVersion = Runtime.version().feature();
- if (runtimeVersion >= 19) {
- assertTrue(
- "on Java 19 or later we should use MemorySegmentIndexInputProvider
to create mmap IndexInputs",
- isMemorySegmentImpl());
- } else {
- assertSame(MappedByteBufferIndexInputProvider.class,
MMapDirectory.PROVIDER.getClass());
- }
- }
-
public void testAceWithThreads() throws Exception {
- assumeTrue("Test requires MemorySegmentIndexInput", isMemorySegmentImpl());
Review Comment:
this is my favorite part of the whole PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
