pmpailis commented on code in PR #13076:
URL: https://github.com/apache/lucene/pull/13076#discussion_r1479470613
##########
lucene/core/src/test/org/apache/lucene/index/KnnGraphTestCase.java:
##########
@@ -54,35 +55,65 @@
import org.apache.lucene.util.Bits;
import org.apache.lucene.util.BytesRef;
import org.apache.lucene.util.IOUtils;
-import org.apache.lucene.util.VectorUtil;
import org.apache.lucene.util.hnsw.HnswGraph;
-import org.apache.lucene.util.hnsw.HnswGraph.NodesIterator;
import org.apache.lucene.util.hnsw.HnswGraphBuilder;
import org.junit.After;
import org.junit.Before;
/** Tests indexing of a knn-graph */
-public class TestKnnGraph extends LuceneTestCase {
Review Comment:
I was in-between excluding hamming distance from float fields or adjusting
tests, to also slightly increase coverage. But yeah, you're right that this is
a bit outside of the scope of this PR. Will revert changes and simply exclude
the similarity when we know it'll throw.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
