uschindler commented on PR #13076: URL: https://github.com/apache/lucene/pull/13076#issuecomment-1927329824
Hi, I don't want to discuss about sense/nonsense of this disatance, but the implementation could been made very simple and then we may not even need to have a Panama Vector variant: - This is just `Long#bitCount(a ^ b)` - a, b should be longs to work effective, so the best would be to replace the loop by using https://lucene.apache.org/core/9_9_1/core/org/apache/lucene/util/BitUtil.html#VH_LE_LONG and iterate using the varhandle. We have another PR already that provides native byte order VarHandles (see #888). As the bitcount of longs does not depend on byte order we can use native byte order. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
