mikemccand commented on PR #12981: URL: https://github.com/apache/lucene/pull/12981#issuecomment-1885233436
> > How serious is this, during off-heap writing? Are we using off-heap writing anywhere in Lucene yet (e.g. block tree)? > > This will break the off-heap writing, as we are writting byte which won't belong to any FST, and it would mess up subsequent reads (if multiple FST are written to the same file) Oh no, I see. Hmm, well could we increment the `numBytesWritten` but use a separately boolean indicating that the lazy byte hasn't been written? It's spooky to have `numBytesWritten = 1` mean it may or may not have been written. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
