mikemccand commented on code in PR #12981:
URL: https://github.com/apache/lucene/pull/12981#discussion_r1447386945
##########
lucene/core/src/java/org/apache/lucene/util/fst/FSTCompiler.java:
##########
@@ -164,14 +164,12 @@ private FSTCompiler(
boolean allowFixedLengthArcs,
DataOutput dataOutput,
float directAddressingMaxOversizingFactor,
- int version)
- throws IOException {
+ int version) {
this.allowFixedLengthArcs = allowFixedLengthArcs;
this.directAddressingMaxOversizingFactor =
directAddressingMaxOversizingFactor;
this.version = version;
// pad: ensure no node gets address 0 which is reserved to mean
- // the stop state w/ no arcs
- dataOutput.writeByte((byte) 0);
+ // the stop state w/ no arcs. the actual byte will be written lazily
Review Comment:
Hmm could we instead add a boolean `paddingBytePending` or so? Set it to
true, here, then when the byte is lazily written, set it to false, write the
byte, and increment `numBytesWritten` at that point? Otherwise it's sort of
weird to increment `numBytesWritten` when we didn't actually write the byte yet?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
