mikemccand commented on code in PR #12981: URL: https://github.com/apache/lucene/pull/12981#discussion_r1447387657
########## lucene/core/src/java/org/apache/lucene/util/fst/FSTCompiler.java: ########## @@ -968,6 +975,9 @@ public FST<T> compile() throws IOException { if (root.numArcs == 0) { if (fst.metadata.emptyOutput == null) { return null; Review Comment: Maybe add a comment that this means a completely empty FST? Accepts nothing? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org