ChrisHegarty commented on code in PR #12903:
URL: https://github.com/apache/lucene/pull/12903#discussion_r1421825998
##########
lucene/core/src/java/org/apache/lucene/util/MSBRadixSorter.java:
##########
@@ -214,6 +214,12 @@ protected int getBucket(int i, int k) {
* @see #buildHistogram
*/
private int computeCommonPrefixLengthAndBuildHistogram(int from, int to, int
k, int[] histogram) {
+ int commonPrefixLength = computeInitialCommonPrefixLength(from, k);
+ return computeCommonPrefixLengthAndBuildHistogramPart1(
+ from, to, k, histogram, commonPrefixLength);
+ }
+
+ private int computeInitialCommonPrefixLength(int from, int k) {
Review Comment:
Yes. I’ll add a comment to that effect.
##########
lucene/core/src/java/org/apache/lucene/util/MSBRadixSorter.java:
##########
@@ -214,6 +214,12 @@ protected int getBucket(int i, int k) {
* @see #buildHistogram
*/
private int computeCommonPrefixLengthAndBuildHistogram(int from, int to, int
k, int[] histogram) {
+ int commonPrefixLength = computeInitialCommonPrefixLength(from, k);
+ return computeCommonPrefixLengthAndBuildHistogramPart1(
+ from, to, k, histogram, commonPrefixLength);
+ }
+
+ private int computeInitialCommonPrefixLength(int from, int k) {
Review Comment:
Yes. I’ll add a comment to that effect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
