uschindler commented on PR #12903: URL: https://github.com/apache/lucene/pull/12903#issuecomment-1859744870
> I've addressed all comments so far. The use of System::getenv is a little annoying, as it required a test-only permission, but it's minimal and make the test very straightforward to run. I made a comment in the main PR (use `Constants#IS_CLIENT_VM`, which was added for vectorization API). The `CI` env var is alos not so useful as Jenkins does not set it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org