mikemccand commented on issue #12895:
URL: https://github.com/apache/lucene/issues/12895#issuecomment-1848561481
OK I turned back on the "old" way (inefficiently concatenating `BytesRef` as
we visit arcs), and then diff'd old and new way when pushing the frame, then
re-ran the `*fo*` `WildcardQuery`. It uncovers a handful of cases where the
accumulator is wrong:
```
IR: StandardDirectoryReader(segments_3:1256
_hc(9.8.1):C3978548:[diagnostics={mergeMaxNumSegments=1,
timestamp=1702127242522, os.version=6.4.11-arch2-1, os=Linux, java.vendor=N/A,
mergeFactor=4, java.runtime.version=21+35, os.arch=amd64, source=merge,
lucene.version=9.8.1}]:[attributes={Lucene90StoredFieldsFormat.mode=BEST_SPEED}]
:id=atd8lnurk6fe2ukuaobcgg5l7)
DIFF: oldWay=[9e c3 a8 1c] newWay=[c3 a8 1c]
DIFF: oldWay=[ae a7 ba 1f] newWay=[a7 ba 1f]
DIFF: oldWay=[a6 b3 97 2b] newWay=[b3 97 2b]
DIFF: oldWay=[82 c4 b2 4c] newWay=[c4 b2 4c]
DIFF: oldWay=[af 8b ba 4c 1 6b b7 4] newWay=[8b ba 4c 1 6b b7 4]
DIFF: oldWay=[c6 92 a7 5a] newWay=[92 a7 5a]
DIFF: oldWay=[e2 a0 db 66] newWay=[a0 db 66]
DIFF: oldWay=[a2 a2 ec 7c] newWay=[a2 ec 7c]
DIFF: oldWay=[9e e6 e0 82 1] newWay=[e6 e0 82 1]
DIFF: oldWay=[b6 aa e3 82 1] newWay=[aa e3 82 1]
DIFF: oldWay=[ee ab 92 8b 1] newWay=[ab 92 8b 1]
DIFF: oldWay=[f2 e2 f5 8b 1] newWay=[e2 f5 8b 1]
DIFF: oldWay=[e2 c3 e5 8d 1] newWay=[c3 e5 8d 1]
DIFF: oldWay=[82 d4 e0 8e 1] newWay=[d4 e0 8e 1]
count for body:"*fo*" is 2871441 vs slow=58963 total_term_count=5759190
```
Here's the new vs old differ patch I used:
[12895-debug.patch](https://github.com/apache/lucene/files/13624978/12895-debug.patch)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
