benwtrent commented on issue #12895:
URL: https://github.com/apache/lucene/issues/12895#issuecomment-1847858897
@mikemccand I have to use at a minimum: `wikibig1m` for it to replicate.
Couple of weird things I noticed in that optimization PR:
-
https://github.com/apache/lucene/pull/12699/files#diff-c30add12e4170e7905cdb0912fd869d447b5b1772d74c9fcaf0afe41cd58866aL200-R204
Now instead of giving a complete view of all appended arcs, there is this
weird assumption that we only give one to `floorDataReader`
-
https://github.com/apache/lucene/pull/12699/files#diff-c30add12e4170e7905cdb0912fd869d447b5b1772d74c9fcaf0afe41cd58866aR200-L202.
The frame outputPrefix is then set as the accumulation of all the arc outputs.
I am not sure if this is relevant as for it to be important `getFrame` would
have to return a frame already seen before, I am not sure if that is valid or
not.
This makes me think that each frame should have its own `OutputAccumulator`
But all this code seems incredibly subtle and opaque to me. Been staring at it
for hours now :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
