uschindler commented on code in PR #12841:
URL: https://github.com/apache/lucene/pull/12841#discussion_r1420375351
##########
lucene/core/src/java/org/apache/lucene/util/GroupVIntUtil.java:
##########
@@ -62,4 +62,42 @@ private static long readLongInGroup(DataInput in, int
numBytesMinus1) throws IOE
return in.readInt() & 0xFFFFFFFFL;
}
}
+
+ /**
+ * Provides an abstraction for read int values, so that decoding logic can
be reused in different DataInput.
+ *
+ */
+ public static interface IntReader {
+ int read(long v);
+ }
+
+ /**
+ * Faster implementation of read single group, It read values from the
buffer that would not cross
+ * boundaries.
+ *
+ * @param flag the flag of group varint.
+ * @param reader the supplier of read int.
+ * @param dst the array to read ints into.
Review Comment:
parameter "pos" is missing in javadocs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
