easyice commented on PR #12841:
URL: https://github.com/apache/lucene/pull/12841#issuecomment-1846784038
+1 for gc overhead, here is the gc output (`-prof gc` ):
```
Benchmark
(size) Mode Cnt Score Error Units
GroupVIntBenchmark.mmap_byteBufferReadGroupVIntUseByteBuffer
64 thrpt 5 1.873 ± 0.269 ops/us
GroupVIntBenchmark.mmap_byteBufferReadGroupVIntUseByteBuffer:gc.alloc.rate
64 thrpt 5 4800.320 ± 690.606 MB/sec
GroupVIntBenchmark.mmap_byteBufferReadGroupVIntUseByteBuffer:gc.alloc.rate.norm
64 thrpt 5 2688.001 ± 0.001 B/op
GroupVIntBenchmark.mmap_byteBufferReadGroupVIntUseByteBuffer:gc.count
64 thrpt 5 273.000 counts
GroupVIntBenchmark.mmap_byteBufferReadGroupVIntUseByteBuffer:gc.time
64 thrpt 5 218.000 ms
GroupVIntBenchmark.mmap_byteBufferReadGroupVInt
64 thrpt 5 8.118 ± 5.922 ops/us
GroupVIntBenchmark.mmap_byteBufferReadGroupVInt:gc.alloc.rate
64 thrpt 5 0.001 ± 0.001 MB/sec
GroupVIntBenchmark.mmap_byteBufferReadGroupVInt:gc.alloc.rate.norm
64 thrpt 5 ≈ 10⁻⁴ B/op
GroupVIntBenchmark.mmap_byteBufferReadGroupVInt:gc.count
64 thrpt 5 ≈ 0 counts
```
> I looked into using lambdas instead, and it seems like it would work well:
It's so cool!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
