jpountz commented on PR #12841:
URL: https://github.com/apache/lucene/pull/12841#issuecomment-1846779641
I confirmed there's GC activity happening with the slice approach by using
`-prof gc`:
```
Benchmark
(size) Mode Cnt Score Error Units
GroupVIntBenchmark.mmap_byteBufferReadGroupVInt
64 thrpt 5 11.482 ± 0.727 ops/us
GroupVIntBenchmark.mmap_byteBufferReadGroupVInt:gc.alloc.rate
64 thrpt 5 0.001 ± 0.001 MB/sec
GroupVIntBenchmark.mmap_byteBufferReadGroupVInt:gc.alloc.rate.norm
64 thrpt 5 ≈ 10⁻⁴ B/op
GroupVIntBenchmark.mmap_byteBufferReadGroupVInt:gc.count
64 thrpt 5 ≈ 0 counts
GroupVIntBenchmark.mmap_byteBufferReadGroupVIntBaseline
64 thrpt 5 6.613 ± 0.504 ops/us
GroupVIntBenchmark.mmap_byteBufferReadGroupVIntBaseline:gc.alloc.rate
64 thrpt 5 0.001 ± 0.001 MB/sec
GroupVIntBenchmark.mmap_byteBufferReadGroupVIntBaseline:gc.alloc.rate.norm
64 thrpt 5 ≈ 10⁻⁴ B/op
GroupVIntBenchmark.mmap_byteBufferReadGroupVIntBaseline:gc.count
64 thrpt 5 ≈ 0 counts
GroupVIntBenchmark.mmap_byteBufferReadGroupVInt_viaByteBuffer
64 thrpt 5 0.153 ± 0.002 ops/us
GroupVIntBenchmark.mmap_byteBufferReadGroupVInt_viaByteBuffer:gc.alloc.rate
64 thrpt 5 2391.134 ± 25.909 MB/sec
GroupVIntBenchmark.mmap_byteBufferReadGroupVInt_viaByteBuffer:gc.alloc.rate.norm
64 thrpt 5 16432.009 ± 0.001 B/op
GroupVIntBenchmark.mmap_byteBufferReadGroupVInt_viaByteBuffer:gc.count
64 thrpt 5 202.000 counts
GroupVIntBenchmark.mmap_byteBufferReadGroupVInt_viaByteBuffer:gc.time
64 thrpt 5 129.000 ms
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
