uschindler commented on PR #12841: URL: https://github.com/apache/lucene/pull/12841#issuecomment-1837150656
Hi, I have no time to review at moment, will come back next week. Some thoughts: - there's copy-paste code missing to MemorySegmentIndexInput for 20 and 19. But wen can do this later. - ByteBufferIndexInput needs code to support MMapDirectory in older Java versions. For both cases above make sure to exactly follow all try catch blocks and calling to super as fone in other bulk read methods. It may also be needed to add a separate test to TestMultiMMap. Also make sure to run tests with Java 17 and Java 19, 20, 21. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
