easyice commented on PR #12841: URL: https://github.com/apache/lucene/pull/12841#issuecomment-1826785154
I did the similarly optimize in `BufferedIndexInput` and `BufferedIndexInput`, The benchmark with java 17 looks fine. In order to observe the diff after overriding `readGroupVInts`,I add `DataInput#readGroupVIntsBaseline` which is copy from `readGroupVInts`, it will be removed after code review. Here is the JMH output for newly optimized, `byteBuffersReadGroupVIntBaseline` and `nioReadGroupVIntBaseline` means use the default implementation (`DataInput#readGroupVIntsBaseline`), the other is their own optimized implementations ``` Benchmark (size) Mode Cnt Score Error Units GroupVIntBenchmark.byteBuffersReadGroupVInt 64 thrpt 5 5.384 ± 1.074 ops/us GroupVIntBenchmark.byteBuffersReadGroupVIntBaseline 64 thrpt 5 2.056 ± 0.365 ops/us GroupVIntBenchmark.nioReadGroupVInt 64 thrpt 5 8.787 ± 1.405 ops/us GroupVIntBenchmark.nioReadGroupVIntBaseline 64 thrpt 5 5.281 ± 0.741 ops/us ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
