stefanvodita commented on code in PR #12844:
URL: https://github.com/apache/lucene/pull/12844#discussion_r1421393091
##########
lucene/core/src/java/org/apache/lucene/util/ArrayUtil.java:
##########
@@ -330,6 +330,29 @@ public static int[] growExact(int[] array, int newLength) {
return copy;
}
+ /**
+ * Returns an array whose size is at least {@code minLength}, generally
over-allocating
+ * exponentially, but never allocating more than {@code maxLength} elements.
+ */
+ public static int[] growInRange(int[] array, int minLength, int maxLength) {
+ if (array.length >= minLength) {
+ return array;
+ }
+ if (minLength > maxLength) {
+ throw new IllegalArgumentException(
+ "requested minimum array length "
+ + minLength
+ + " is larger than requested maximum array length "
+ + maxLength);
+ }
Review Comment:
I thought about this some more and I applied your suggestion in the latest
commit. I still think there's a case where checking first will be inconvenient,
e.g. if we don't have information about `maxLength` where we initialize the
array and we end up initializing to a capacity larger than `maxLength`. But
this is hypothetical, maybe we don't have any cases like that in the code base.
At this time, I agree the proposal you two made is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
