dungba88 commented on code in PR #12844:
URL: https://github.com/apache/lucene/pull/12844#discussion_r1412215432
##########
lucene/core/src/java/org/apache/lucene/util/hnsw/NeighborArray.java:
##########
@@ -32,17 +32,20 @@
* @lucene.internal
*/
public class NeighborArray {
+ private static final int INITIAL_CAPACITY = 10;
private final boolean scoresDescOrder;
+ private final int maxSize;
private int size;
float[] score;
int[] node;
private int sortedNodeSize;
public final ReadWriteLock rwlock = new ReentrantReadWriteLock(true);
public NeighborArray(int maxSize, boolean descOrder) {
- node = new int[maxSize];
- score = new float[maxSize];
+ node = new int[INITIAL_CAPACITY];
Review Comment:
Could it be due to the over-allocation that every node now needs to allocate
1000 size array whether they need it or not?
I think that's the more reason we should use min(INITIAL_SIZE, maxSize)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
