gsmiller commented on code in PR #12853: URL: https://github.com/apache/lucene/pull/12853#discussion_r1409693152
########## lucene/CHANGES.txt: ########## @@ -112,6 +112,9 @@ Bug Fixes * GITHUB#12220: Hunspell: disallow hidden title-case entries from compound middle/end +* GITHUB#12558: Ensure #finish is called on all drill-sideways FacetsCollectors even when no hits are scored. Review Comment: Put this under 10.0 for now. After 9.9, if we add a section for 9.10 I will back port it there (no reason not to, we just don't have the section setup). Also, if 9.9 re-spins I will back port to 9.9, but we shouldn't block that release for this fix IMO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org