gautamworah96 commented on code in PR #12853:
URL: https://github.com/apache/lucene/pull/12853#discussion_r1421077089
##########
lucene/facet/src/java/org/apache/lucene/facet/DrillSidewaysQuery.java:
##########
@@ -193,42 +204,29 @@ public BulkScorer bulkScorer(LeafReaderContext context)
throws IOException {
FacetsCollector sidewaysCollector =
drillSidewaysCollectorManagers[dim].newCollector();
sidewaysCollectors[dim] = sidewaysCollector;
- dims[dim] = new DrillSidewaysScorer.DocsAndCost(scorer,
sidewaysCollector);
+ dims[dim] =
+ new DrillSidewaysScorer.DocsAndCost(
+ scorer, sidewaysCollector.getLeafCollector(context));
}
- // If more than one dim has no matches, then there
- // are no hits nor drill-sideways counts. Or, if we
- // have only one dim and that dim has no matches,
- // same thing.
Review Comment:
unrelated but how exactly is `(nullCount > 1 || (nullCount == 1 &&
dims.length == 1))` equivalent to `nullCount > 1`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
