slow-J commented on PR #12797: URL: https://github.com/apache/lucene/pull/12797#issuecomment-1819836777
> This looks fantastic! I left a minor comment, I think a mention in `MIGRATE.md` is valuable for this change. > > It would be good to get another reviewer to make sure I didn't miss something as checkindex is really critical. Thanks for the review and approval @rmuir! Added the MIGRATE.md note there. I think @mikemccand was looking into `CheckIndex` recently, so maybe he may be interested in this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
