slow-J commented on code in PR #12797:
URL: https://github.com/apache/lucene/pull/12797#discussion_r1400997709
##########
lucene/MIGRATE.md:
##########
@@ -101,6 +101,13 @@ The deprecated getter for the `Executor` that was
optionally provided to the `In
has been removed. Users that want to execute concurrent tasks should rely
instead on the `TaskExecutor`
that the searcher holds, retrieved via `IndexSearcher#getTaskExecutor`.
+### CheckIndex params -slow and -fast are deprecated, replaced by -level X
(GITHUB#11023)
+
+The `CheckIndex` former `-fast` behaviour of performing checksum checks only,
is now the default.
+Added a new parameter: `-level X`, to set the detail level of the index check.
The higher the value, the more checks are performed.
+Sample `-level` usage: `1` (Default) - Checksum checks only, `2` - all level 1
checks as well as logical integrity checks, `3` - all
+level 2 checks as well as slow checks.
Review Comment:
Yes, they are inclusive. There is no 4 currently.
##########
lucene/core/src/java/org/apache/lucene/index/CheckIndex.java:
##########
@@ -442,19 +442,19 @@ public void close() throws IOException {
IOUtils.close(writeLock);
}
- private boolean doSlowChecks;
+ private int level;
/**
- * If true, additional slow checks are performed. This will likely
drastically increase time it
- * takes to run CheckIndex!
+ * Sets Level, the higher the value, the more additional checks are
performed. This will likely
+ * drastically increase time it takes to run CheckIndex! See {@link Level}
*/
- public void setDoSlowChecks(boolean v) {
- doSlowChecks = v;
+ public void setLevel(int v) {
+ level = v;
Review Comment:
We do `throw IllegalArgumentException` if the input is below or above the
limit :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
