rmuir commented on code in PR #12797:
URL: https://github.com/apache/lucene/pull/12797#discussion_r1390277688
##########
lucene/core/src/java/org/apache/lucene/index/CheckIndex.java:
##########
@@ -3974,7 +3974,7 @@ public static class Options {
boolean doExorcise = false;
boolean doSlowChecks = false;
boolean verbose = false;
- boolean doChecksumsOnly = false;
+ boolean doChecksumsOnly = true;
Review Comment:
and feel free to think of alternative way to integrate this other than
`-slow`, `-slower`, etc. It is a breaking change, major release is a good time
to do it IMO, but maybe it could be done via numeric level (like verbosity in
other commandline tools) or some other way? It would eliminate the booleans too
which aren't great. And I think we should take checkindex API in to
consideration for this change as well, for anyone calling it programmatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
