zacharymorn commented on code in PR #240:
URL: https://github.com/apache/lucene/pull/240#discussion_r1387443316


##########
lucene/core/src/java/org/apache/lucene/search/TopFieldCollector.java:
##########
@@ -174,7 +173,7 @@ private static boolean canEarlyTerminateOnPrefix(Sort 
searchSort, Sort indexSort
    * Implements a TopFieldCollector over one SortField criteria, with tracking

Review Comment:
   I feel extending or instantiating collectors should still be allowed, as 
long as they are done inside collector managers, and this would become 
enforceable once we fully deprecate `IndexSearch#search(Query, Collector)`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to