zacharymorn commented on PR #240: URL: https://github.com/apache/lucene/pull/240#issuecomment-1811972923
> Hi @mikemccand @jpountz @javanna @gsmiller , I have updated this PR to pick up the latest from `main`, as well as revert some changes to save them for follow-up PRs that address other collectors. This PR is now focused on the following: > > * Refactor out TopScoreDocCollectorManager, TopFieldCollectorManager > * Refactor some tests to use the above collector manager > > Could you please take a look, and let me know if you have any feedback? Hi @jpountz @javanna @gsmiller, just want to have a quick follow-up to see if you may have any further feedback on this PR? I plan to merge it in the next few days if there's no major concern. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
